diff options
author | Lai Jiangshan <laijs@cn.fujitsu.com> | 2014-04-18 11:04:16 -0400 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2014-04-18 11:04:16 -0400 |
commit | 4d595b866d2c653dc90a492b9973a834eabfa354 (patch) | |
tree | 6b9a9af0eb01436a3967eff0a5c916e80cf0ef5f /MAINTAINERS | |
parent | 77f300b198f93328c26191b52655ce1b62e202cf (diff) | |
download | linux-4d595b866d2c653dc90a492b9973a834eabfa354.tar.bz2 |
workqueue: make rescuer_thread() empty wq->maydays list before exiting
After a @pwq is scheduled for emergency execution, other workers may
consume the affectd work items before the rescuer gets to them. This
means that a workqueue many have pwqs queued on @wq->maydays list
while not having any work item pending or in-flight. If
destroy_workqueue() executes in such condition, the rescuer may exit
without emptying @wq->maydays.
This currently doesn't cause any actual harm. destroy_workqueue() can
safely destroy all the involved data structures whether @wq->maydays
is populated or not as nobody access the list once the rescuer exits.
However, this is nasty and makes future development difficult. Let's
update rescuer_thread() so that it empties @wq->maydays after seeing
should_stop to guarantee that the list is empty on rescuer exit.
tj: Updated comment and patch description.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org # v3.10+
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions