diff options
author | Kyle Moffett <Kyle.D.Moffett@boeing.com> | 2011-12-22 10:19:09 +0000 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2012-02-23 10:49:58 +1100 |
commit | 3a7a7176e840f448aae929f7761ea80cf892c665 (patch) | |
tree | 8e4c90c6cb951801fa01db37ba278e4e1f4da17b /Documentation/devicetree/bindings/powerpc | |
parent | 27e74da9800289e69ba907777df1e2085231eff7 (diff) | |
download | linux-3a7a7176e840f448aae929f7761ea80cf892c665.tar.bz2 |
powerpc/mpic: Fix use of "flags" variable in mpic_alloc()
The mpic_alloc() function takes a "flags" parameter and assigns it into
the mpic->flags variable fairly early on, but several later pieces of
code detect various device-tree properties and save them into the
"mpic->flags" variable (EG: "big-endian" => MPIC_BIG_ENDIAN).
Unfortunately, a number of codepaths (including several which test the
flag MPIC_BIG_ENDIAN!) test "flags" instead of "mpic->flags", and get
wrong answers as a result.
Consolidate the device-tree flag tests early in mpic_alloc() and change
all of the checks after "mpic->flags" is init'ed to use "mpic->flags".
[BenH: Fixed up use of mpic->node before it's initialized]
Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'Documentation/devicetree/bindings/powerpc')
0 files changed, 0 insertions, 0 deletions