diff options
| author | Heiko Stuebner <heiko.stuebner@theobroma-systems.com> | 2020-01-21 23:48:28 +0100 |
|---|---|---|
| committer | Heiko Stuebner <heiko@sntech.de> | 2020-03-11 09:44:14 +0100 |
| commit | 7cd7943dc55e0f75a8e51af2bbdb2b0415cc3eb7 (patch) | |
| tree | 00f649e0b27b87e3c22d3cf83e31c864f890b80c | |
| parent | 8efef33eff5088ecc748e9d5b3bff6c1c955348f (diff) | |
| download | linux-7cd7943dc55e0f75a8e51af2bbdb2b0415cc3eb7.tar.bz2 | |
drm/rockchip: rgb: don't count non-existent devices when determining subdrivers
rockchip_drm_endpoint_is_subdriver() may also return error codes.
For example if the target-node is in the disabled state, so no
platform-device is getting created for it.
In that case current code would count that as external rgb device,
which in turn would make probing the rockchip-drm device fail.
So only count the target as rgb device if the function actually
returns 0.
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200121224828.4070067-1-heiko@sntech.de
| -rw-r--r-- | drivers/gpu/drm/rockchip/rockchip_rgb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c index 3e2484985955..90784781e515 100644 --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c @@ -98,7 +98,8 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev, if (of_property_read_u32(endpoint, "reg", &endpoint_id)) endpoint_id = 0; - if (rockchip_drm_endpoint_is_subdriver(endpoint) > 0) + /* if subdriver (> 0) or error case (< 0), ignore entry */ + if (rockchip_drm_endpoint_is_subdriver(endpoint) != 0) continue; child_count++; |