summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHaowen Bai <baihaowen@meizu.com>2022-03-15 16:53:41 +0800
committerVasily Gorbik <gor@linux.ibm.com>2022-03-27 22:18:38 +0200
commit081397d13f9cfcc10e5bc903559419f6bfc31cca (patch)
treec327610a744c24064c5aa127540531b52197ba89
parent6ffbeb3fac9d1518109b4adfbe605028883fb181 (diff)
downloadlinux-081397d13f9cfcc10e5bc903559419f6bfc31cca.tar.bz2
s390/tape: use bitwise instead of arithmetic operator for flags
This silences the following coccinelle warning: drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider | Signed-off-by: Haowen Bai <baihaowen@meizu.com> Link: https://lore.kernel.org/r/1647334421-29989-1-git-send-email-baihaowen@meizu.com Signed-off-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
-rw-r--r--drivers/s390/char/tape_34xx.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/s390/char/tape_34xx.c b/drivers/s390/char/tape_34xx.c
index 7ada994d4592..38cc1565d6ae 100644
--- a/drivers/s390/char/tape_34xx.c
+++ b/drivers/s390/char/tape_34xx.c
@@ -354,10 +354,10 @@ tape_34xx_unit_check(struct tape_device *device, struct tape_request *request,
if ((
sense[0] == SENSE_DATA_CHECK ||
sense[0] == SENSE_EQUIPMENT_CHECK ||
- sense[0] == SENSE_EQUIPMENT_CHECK + SENSE_DEFERRED_UNIT_CHECK
+ sense[0] == (SENSE_EQUIPMENT_CHECK | SENSE_DEFERRED_UNIT_CHECK)
) && (
sense[1] == SENSE_DRIVE_ONLINE ||
- sense[1] == SENSE_BEGINNING_OF_TAPE + SENSE_WRITE_MODE
+ sense[1] == (SENSE_BEGINNING_OF_TAPE | SENSE_WRITE_MODE)
)) {
switch (request->op) {
/*