diff options
| author | Ihar Hrachyshka <ihrachys@redhat.com> | 2017-05-24 15:19:35 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-05-25 13:38:20 -0400 |
| commit | 5990baaa6d7b437dfcf58b7021ca56b1d6b35869 (patch) | |
| tree | 28108a28ba1863c260df7228e2a5f51c0f981113 | |
| parent | ba615f675281d76fd19aa03558777f81fb6b6084 (diff) | |
| download | linux-5990baaa6d7b437dfcf58b7021ca56b1d6b35869.tar.bz2 | |
arp: fixed -Wuninitialized compiler warning
Commit 7d472a59c0e5ec117220a05de6b370447fb6cb66 ("arp: always override
existing neigh entries with gratuitous ARP") introduced a compiler
warning:
net/ipv4/arp.c:880:35: warning: 'addr_type' may be used uninitialized in
this function [-Wmaybe-uninitialized]
While the code logic seems to be correct and doesn't allow the variable
to be used uninitialized, and the warning is not consistently
reproducible, it's still worth fixing it for other people not to waste
time looking at the warning in case it pops up in the build environment.
Yes, compiler is probably at fault, but we will need to accommodate.
Fixes: 7d472a59c0e5 ("arp: always override existing neigh entries with gratuitous ARP")
Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/arp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index ae96e6f3e0cb..e9f3386a528b 100644 --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c @@ -863,8 +863,8 @@ static int arp_process(struct net *net, struct sock *sk, struct sk_buff *skb) n = __neigh_lookup(&arp_tbl, &sip, dev, 0); + addr_type = -1; if (n || IN_DEV_ARP_ACCEPT(in_dev)) { - addr_type = -1; is_garp = arp_is_garp(net, dev, &addr_type, arp->ar_op, sip, tip, sha, tha); } |