diff options
| author | Pavel Machek <pavel@ucw.cz> | 2020-03-09 23:33:23 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-11 23:15:26 -0700 |
| commit | dacf470b26418e91bef195342b25a234c94052e3 (patch) | |
| tree | 21bab91497fa718133eb064b9e763a254a8a36b2 | |
| parent | c7211ff3be0fa98a55920f876608cc9e13c9eb5f (diff) | |
| download | linux-dacf470b26418e91bef195342b25a234c94052e3.tar.bz2 | |
net: slcan, slip -- no need for goto when if () will do
No need to play with gotos to jump over single statement.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/can/slcan.c | 7 | ||||
| -rw-r--r-- | drivers/net/slip/slip.c | 7 |
2 files changed, 4 insertions, 10 deletions
diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c index 2f5c287eac95..686d853fc249 100644 --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c @@ -348,11 +348,8 @@ static void slcan_write_wakeup(struct tty_struct *tty) rcu_read_lock(); sl = rcu_dereference(tty->disc_data); - if (!sl) - goto out; - - schedule_work(&sl->tx_work); -out: + if (sl) + schedule_work(&sl->tx_work); rcu_read_unlock(); } diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c index babb01888b78..f81fb0b13a94 100644 --- a/drivers/net/slip/slip.c +++ b/drivers/net/slip/slip.c @@ -456,11 +456,8 @@ static void slip_write_wakeup(struct tty_struct *tty) rcu_read_lock(); sl = rcu_dereference(tty->disc_data); - if (!sl) - goto out; - - schedule_work(&sl->tx_work); -out: + if (sl) + schedule_work(&sl->tx_work); rcu_read_unlock(); } |