diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2017-09-26 11:21:24 -0700 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2017-09-28 09:13:06 -0700 |
| commit | c1fb3542074fd0c4d901d778bd52455111e4eb6f (patch) | |
| tree | 1271745a621c28817bced029c293dae3cf6cffe1 | |
| parent | b8ff981f88df03c72a4de2f6eaa9ce447a10ac03 (diff) | |
| download | linux-c1fb3542074fd0c4d901d778bd52455111e4eb6f.tar.bz2 | |
libnvdimm, namespace: make 'resource' attribute only readable by root
For the same reason that /proc/iomem returns 0's for non-root readers
and acpi tables are root-only, make the 'resource' attribute for
namespace devices only readable by root. Otherwise we disclose physical
address information.
Fixes: bf9bccc14c05 ("libnvdimm: pmem label sets and namespace instantiation")
Cc: <stable@vger.kernel.org>
Reported-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
| -rw-r--r-- | drivers/nvdimm/namespace_devs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c index 3e4d1e7998da..0af988739a06 100644 --- a/drivers/nvdimm/namespace_devs.c +++ b/drivers/nvdimm/namespace_devs.c @@ -1620,7 +1620,7 @@ static umode_t namespace_visible(struct kobject *kobj, if (a == &dev_attr_resource.attr) { if (is_namespace_blk(dev)) return 0; - return a->mode; + return 0400; } if (is_namespace_pmem(dev) || is_namespace_blk(dev)) { |