diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2016-01-02 14:50:51 -0500 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2016-01-04 10:29:40 -0500 |
| commit | 1ceb36285c256347ffa062b7b1b593f801b6697b (patch) | |
| tree | 8537ec6178399f41b52f45753f7eadb69b68af18 | |
| parent | 80f8dccf95147f9668eee021425ecf3ff6432c51 (diff) | |
| download | linux-1ceb36285c256347ffa062b7b1b593f801b6697b.tar.bz2 | |
[um] hostaudio: don't open-code memdup_user()
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| -rw-r--r-- | arch/um/drivers/hostaudio_kern.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/arch/um/drivers/hostaudio_kern.c b/arch/um/drivers/hostaudio_kern.c index f6b911cc3923..3a4b58730f5f 100644 --- a/arch/um/drivers/hostaudio_kern.c +++ b/arch/um/drivers/hostaudio_kern.c @@ -105,13 +105,9 @@ static ssize_t hostaudio_write(struct file *file, const char __user *buffer, printk(KERN_DEBUG "hostaudio: write called, count = %d\n", count); #endif - kbuf = kmalloc(count, GFP_KERNEL); - if (kbuf == NULL) - return -ENOMEM; - - err = -EFAULT; - if (copy_from_user(kbuf, buffer, count)) - goto out; + kbuf = memdup_user(buffer, count); + if (IS_ERR(kbuf)) + return PTR_ERR(kbuf); err = os_write_file(state->fd, kbuf, count); if (err < 0) |