diff options
| author | Paul Blakey <paulb@mellanox.com> | 2020-03-18 12:50:33 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-18 16:37:06 -0700 |
| commit | dd2af10402684cb5840a127caec9e7cdcff6d167 (patch) | |
| tree | 8d85f700e3cd5db399caab601042acc97879f1e2 | |
| parent | 2de9780f75076c1a1f122cbd39df0fa545284724 (diff) | |
| download | linux-dd2af10402684cb5840a127caec9e7cdcff6d167.tar.bz2 | |
net/sched: act_ct: Fix leak of ct zone template on replace
Currently, on replace, the previous action instance params
is swapped with a newly allocated params. The old params is
only freed (via kfree_rcu), without releasing the allocated
ct zone template related to it.
Call tcf_ct_params_free (via call_rcu) for the old params,
so it will release it.
Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
Signed-off-by: Paul Blakey <paulb@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sched/act_ct.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c index f685c0d73708..41114b463161 100644 --- a/net/sched/act_ct.c +++ b/net/sched/act_ct.c @@ -739,7 +739,7 @@ static int tcf_ct_init(struct net *net, struct nlattr *nla, if (goto_ch) tcf_chain_put_by_act(goto_ch); if (params) - kfree_rcu(params, rcu); + call_rcu(¶ms->rcu, tcf_ct_params_free); if (res == ACT_P_CREATED) tcf_idr_insert(tn, *a); |