diff options
| author | WANG Cong <xiyou.wangcong@gmail.com> | 2017-07-20 11:27:57 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-07-20 15:23:22 -0700 |
| commit | 153711f9421be5dbc973dc57a4109dc9d54c89b1 (patch) | |
| tree | 06308fcd9cd16cf966d238f9ee60e6bac1a62e3f | |
| parent | be35e8c516c1915a3035d266a2015b41f73ba3f9 (diff) | |
| download | linux-153711f9421be5dbc973dc57a4109dc9d54c89b1.tar.bz2 | |
rtnetlink: allocate more memory for dev_set_mac_address()
virtnet_set_mac_address() interprets mac address as struct
sockaddr, but upper layer only allocates dev->addr_len
which is ETH_ALEN + sizeof(sa_family_t) in this case.
We lack a unified definition for mac address, so just fix
the upper layer, this also allows drivers to interpret it
to struct sockaddr freely.
Reported-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/rtnetlink.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 11b25fbf3dd2..9201e3621351 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -2031,7 +2031,8 @@ static int do_setlink(const struct sk_buff *skb, struct sockaddr *sa; int len; - len = sizeof(sa_family_t) + dev->addr_len; + len = sizeof(sa_family_t) + max_t(size_t, dev->addr_len, + sizeof(*sa)); sa = kmalloc(len, GFP_KERNEL); if (!sa) { err = -ENOMEM; |