diff options
| author | Kangjie Lu <kangjielu@gmail.com> | 2016-05-03 16:44:20 -0400 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2016-05-08 11:36:07 +0200 |
| commit | 9a47e9cff994f37f7f0dbd9ae23740d0f64f9fe6 (patch) | |
| tree | 189f139d4b14fb076aa57e8c2287e4f6eb70e59d | |
| parent | cec8f96e49d9be372fdb0c3836dcf31ec71e457e (diff) | |
| download | linux-9a47e9cff994f37f7f0dbd9ae23740d0f64f9fe6.tar.bz2 | |
ALSA: timer: Fix leak in events via snd_timer_user_ccallback
The stack object “r1” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/core/timer.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/core/timer.c b/sound/core/timer.c index 306a93dea20a..cc3c08d17ab1 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -1223,6 +1223,7 @@ static void snd_timer_user_ccallback(struct snd_timer_instance *timeri, tu->tstamp = *tstamp; if ((tu->filter & (1 << event)) == 0 || !tu->tread) return; + memset(&r1, 0, sizeof(r1)); r1.event = event; r1.tstamp = *tstamp; r1.val = resolution; |