diff options
| author | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2019-10-13 10:55:15 +0100 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2019-10-18 19:52:03 +0100 |
| commit | 78b75ab3f8c9dfac563b81105a1b838ec37a940e (patch) | |
| tree | b2e8bcc6a0209ac83b801b3ce08a9207b6995130 | |
| parent | 47f3b26e708b59dcb10eae2db79bf3aeecfdd9e5 (diff) | |
| download | linux-78b75ab3f8c9dfac563b81105a1b838ec37a940e.tar.bz2 | |
iio: chemical: sps30: Explicity truncate constant by masking
When breaking up a constant to write to two 8 bit registers
it isn't obvious to sparse that it was intentional.
CHECK drivers/iio/chemical/sps30.c
drivers/iio/chemical/sps30.c:120:30: warning: cast truncates bits from constant value (8004 becomes 4)
So in the interests of minimising noisy warnings, let us add
a mask.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Tomasz Duszynski <tduszyns@gmail.com>
| -rw-r--r-- | drivers/iio/chemical/sps30.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/chemical/sps30.c b/drivers/iio/chemical/sps30.c index edbb956e81e8..acb9f8ecbb3d 100644 --- a/drivers/iio/chemical/sps30.c +++ b/drivers/iio/chemical/sps30.c @@ -117,7 +117,7 @@ static int sps30_do_cmd(struct sps30_state *state, u16 cmd, u8 *data, int size) break; case SPS30_READ_AUTO_CLEANING_PERIOD: buf[0] = SPS30_AUTO_CLEANING_PERIOD >> 8; - buf[1] = (u8)SPS30_AUTO_CLEANING_PERIOD; + buf[1] = (u8)(SPS30_AUTO_CLEANING_PERIOD & 0xff); /* fall through */ case SPS30_READ_DATA_READY_FLAG: case SPS30_READ_DATA: |