summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrian Vazquez <brianvv@google.com>2019-10-01 10:37:28 -0700
committerDaniel Borkmann <daniel@iogearbox.net>2019-10-02 00:58:07 +0200
commita2d074e4c6e81ec9ab359d54f0b88273c738de37 (patch)
treee6302a510716d7cdbe7654c7faf956d9dcc4e2b9
parent86c1aea84b97120a6d428ce17a2ebd55be677f56 (diff)
downloadlinux-a2d074e4c6e81ec9ab359d54f0b88273c738de37.tar.bz2
selftests/bpf: test_progs: Don't leak server_fd in test_sockopt_inherit
server_fd needs to be closed if pthread can't be created. Fixes: e3e02e1d9c24 ("selftests/bpf: test_progs: convert test_sockopt_inherit") Signed-off-by: Brian Vazquez <brianvv@google.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Reviewed-by: Stanislav Fomichev <sdf@google.com> Link: https://lore.kernel.org/bpf/20191001173728.149786-3-brianvv@google.com
-rw-r--r--tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c b/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
index 6cbeea7b4bf1..8547ecbdc61f 100644
--- a/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
@@ -195,7 +195,7 @@ static void run_test(int cgroup_fd)
if (CHECK_FAIL(pthread_create(&tid, NULL, server_thread,
(void *)&server_fd)))
- goto close_bpf_object;
+ goto close_server_fd;
pthread_mutex_lock(&server_started_mtx);
pthread_cond_wait(&server_started, &server_started_mtx);