summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMasahiro Yamada <yamada.masahiro@socionext.com>2018-09-18 17:45:52 +0900
committerMasahiro Yamada <yamada.masahiro@socionext.com>2018-10-04 22:56:02 +0900
commit74bc0c09b2da005f028510b1ad21140c9d6c9b44 (patch)
tree031cccbf9287374dfcfeb5bae07267de6755497c
parent77ec0c20c7e012b5ebb22197c8a329611458cdf8 (diff)
downloadlinux-74bc0c09b2da005f028510b1ad21140c9d6c9b44.tar.bz2
kbuild: remove user ID check in scripts/mkmakefile
This line was added by commit fd5f0cd6b0ce ("kbuild: Do not overwrite makefile as anohter user"). Its commit description says the intention was to prevent $(objtree)/Makefile from being owned by root when e.g. running 'make install'. However, as commit 19514fc665ff ("arm, kbuild: make "make install" not depend on vmlinux") stated, installation targets must not modify the source tree in the first place. If they do, we are already screwed up. We must fix the root cause. Installation targets should just copy files verbatim, hence we never expect $(objtree)/Makefile is touched by root. The user ID check in scripts/mkmakefile is unneeded. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
-rwxr-xr-xscripts/mkmakefile1
1 files changed, 0 insertions, 1 deletions
diff --git a/scripts/mkmakefile b/scripts/mkmakefile
index e21064445085..24354284d4ad 100755
--- a/scripts/mkmakefile
+++ b/scripts/mkmakefile
@@ -8,7 +8,6 @@
# $1 - Kernel src directory
# $2 - Output directory
-test ! -r $2/Makefile -o -O $2/Makefile || exit 0
# Only overwrite automatically generated Makefiles
# (so we do not overwrite kernel Makefile)
if test -e $2/Makefile && ! grep -q Automatically $2/Makefile