summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjorn Helgaas <bhelgaas@google.com>2016-10-06 13:29:02 -0500
committerBjorn Helgaas <bhelgaas@google.com>2016-10-11 19:54:23 -0500
commitdbeb4bd8bae584408ce7e09b29510e2b5cb85bbb (patch)
treef29ee967df99ef2d39ac82d90a71aecf2be6df78
parentee34264eec4838e336e0af756e6ec84d5159ee41 (diff)
downloadlinux-dbeb4bd8bae584408ce7e09b29510e2b5cb85bbb.tar.bz2
PCI: altera: Remove redundant platform_get_resource() return value check
devm_ioremap_resource() fails gracefully when given a NULL resource pointer, so we don't need to check separately for failure from platform_get_resource_byname(). Remove the redundant check. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
-rw-r--r--drivers/pci/host/pcie-altera.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
index b26695cbc433..931c51ed471e 100644
--- a/drivers/pci/host/pcie-altera.c
+++ b/drivers/pci/host/pcie-altera.c
@@ -74,7 +74,7 @@
struct altera_pcie {
struct platform_device *pdev;
- void __iomem *cra_base;
+ void __iomem *cra_base; /* DT Cra */
int irq;
u8 root_bus_nr;
struct irq_domain *irq_domain;
@@ -555,11 +555,6 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie)
struct resource *cra;
cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra");
- if (!cra) {
- dev_err(dev, "no Cra memory resource defined\n");
- return -ENODEV;
- }
-
pcie->cra_base = devm_ioremap_resource(dev, cra);
if (IS_ERR(pcie->cra_base)) {
dev_err(dev, "failed to map cra memory\n");