diff options
| author | Mian Yousaf Kaukab <ykaukab@suse.de> | 2019-12-05 10:41:16 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-12-05 12:10:40 -0800 |
| commit | a350d2e7adbb57181d33e3aa6f0565632747feaa (patch) | |
| tree | 80f4c8825f202d728a7ca658dda4e61e5a317534 | |
| parent | df95467b6d2bfce49667ee4b71c67249b01957f7 (diff) | |
| download | linux-a350d2e7adbb57181d33e3aa6f0565632747feaa.tar.bz2 | |
net: thunderx: start phy before starting autonegotiation
Since commit 2b3e88ea6528 ("net: phy: improve phy state checking")
phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start()
before calling phy_start_aneg() during probe so that autonegotiation
is initiated.
As phy_start() takes care of calling phy_start_aneg(), drop the explicit
call to phy_start_aneg().
Network fails without this patch on Octeon TX.
Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index 1e09fdb63c4f..c4f6ec0cd183 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -1115,7 +1115,7 @@ static int bgx_lmac_enable(struct bgx *bgx, u8 lmacid) phy_interface_mode(lmac->lmac_type))) return -ENODEV; - phy_start_aneg(lmac->phydev); + phy_start(lmac->phydev); return 0; } |