diff options
| author | Colin Ian King <colin.king@canonical.com> | 2016-01-25 16:25:54 +0000 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2016-02-10 18:04:53 -0600 |
| commit | 997152f62751b7d16f1b864121c912fd19032bdf (patch) | |
| tree | 25709cdc1d7c816df484fc477c57eacb70d0187d | |
| parent | 74c7b2af37ad431c3b69961a5cdbd0a92292c92a (diff) | |
| download | linux-997152f62751b7d16f1b864121c912fd19032bdf.tar.bz2 | |
cifs: remove redundant check for null string pointer
server_RFC1001_name is declared as a RFC1001_NAME_LEN_WITH_NULL sized
char array in struct TCP_Server_Info so the null pointer check on
server_RFC1001_name is redundant and can be removed. Detected with
smatch:
fs/cifs/connect.c:2982 ip_rfc1001_connect() warn: this array is probably
non-NULL. 'server->server_RFC1001_name'
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steve French <smfrench@gmail.com>
| -rw-r--r-- | fs/cifs/connect.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 4fbd92d2e113..a763cd3d9e7c 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -2999,8 +2999,7 @@ ip_rfc1001_connect(struct TCP_Server_Info *server) if (ses_init_buf) { ses_init_buf->trailer.session_req.called_len = 32; - if (server->server_RFC1001_name && - server->server_RFC1001_name[0] != 0) + if (server->server_RFC1001_name[0] != 0) rfc1002mangle(ses_init_buf->trailer. session_req.called_name, server->server_RFC1001_name, |