diff options
| author | Nicholas Bellinger <nab@linux-iscsi.org> | 2011-11-30 18:24:03 -0800 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2011-12-14 11:53:29 +0000 |
| commit | 6d5b59756033c2a029bde7262bb5f8d45f4ca952 (patch) | |
| tree | 01cf728296b46e5af005307859e890ef839e063d | |
| parent | beb55a0cc15a43be43a646b588fcf83822f0c44f (diff) | |
| download | linux-6d5b59756033c2a029bde7262bb5f8d45f4ca952.tar.bz2 | |
target: Remove legacy device status check from transport_execute_tasks
This patch removes a legacy se_dev_check_online() check from within
transport_execute_tasks() that should no longer be necessary as
transport_lookup_cmd_lun() is already making this call.
Using transport_cmd_check_stop() from transport_execute_tasks() should
already be checking per se_cmd context for each descriptor upon active
I/O shutdown, so no need to acquire dev->dev_status_lock again while
executing se_task submission.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Roland Dreier <roland@purestorage.com>
Cc: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
| -rw-r--r-- | drivers/target/target_core_transport.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 373e01f523dd..b5fdacce0671 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -2062,13 +2062,6 @@ static int transport_execute_tasks(struct se_cmd *cmd) { int add_tasks; struct se_device *se_dev = cmd->se_dev; - - if (se_dev_check_online(cmd->se_dev) != 0) { - cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; - transport_generic_request_failure(cmd); - return 0; - } - /* * Call transport_cmd_check_stop() to see if a fabric exception * has occurred that prevents execution. |