diff options
| author | Dan Murphy <dmurphy@ti.com> | 2015-07-21 12:06:45 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-07-21 22:29:31 -0700 |
| commit | a46fa260f6f5e8f80a725b28e4aee5a04d1bd79e (patch) | |
| tree | ddc9b4f6cba938e1383f21b90bc8c7851ccbe58c | |
| parent | bac541e46319c2dc6ff9fd5ad6df59cd38686bdb (diff) | |
| download | linux-a46fa260f6f5e8f80a725b28e4aee5a04d1bd79e.tar.bz2 | |
net: phy: dp83867: Fix warning check for setting the internal delay
Fix warning: logical ‘or’ of collectively exhaustive tests is always true
Change the internal delay check from an 'or' condition to an 'and'
condition.
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Dan Murphy <dmurphy@ti.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/dp83867.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index c7a12e2e07b7..8a3bf5469892 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -164,7 +164,7 @@ static int dp83867_config_init(struct phy_device *phydev) return ret; } - if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) || + if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) && (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) { val = phy_read_mmd_indirect(phydev, DP83867_RGMIICTL, DP83867_DEVADDR, phydev->addr); |