diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2014-08-26 12:24:24 +0200 |
|---|---|---|
| committer | Benjamin Gaignard <benjamin.gaignard@linaro.org> | 2014-08-26 14:16:51 +0200 |
| commit | eacd9aa98bdeef5ba19072d3f07dfcccd24988f2 (patch) | |
| tree | d2811163841b4b1cab93f56d0a4313e4fe6246ac | |
| parent | 5024a2b7ae9a92b8ec97ac1507efb283778480ce (diff) | |
| download | linux-eacd9aa98bdeef5ba19072d3f07dfcccd24988f2.tar.bz2 | |
drm: sti: Fix return value check in sti_drm_platform_probe()
In case of error, the function platform_device_register_resndata()
returns ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
| -rw-r--r-- | drivers/gpu/drm/sti/sti_drm_drv.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/sti/sti_drm_drv.c b/drivers/gpu/drm/sti/sti_drm_drv.c index a7cc24917a96..223d93c3a05d 100644 --- a/drivers/gpu/drm/sti/sti_drm_drv.c +++ b/drivers/gpu/drm/sti/sti_drm_drv.c @@ -201,8 +201,8 @@ static int sti_drm_platform_probe(struct platform_device *pdev) master = platform_device_register_resndata(dev, DRIVER_NAME "__master", -1, NULL, 0, NULL, 0); - if (!master) - return -EINVAL; + if (IS_ERR(master)) + return PTR_ERR(master); platform_set_drvdata(pdev, master); return 0; |