summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmerigo Wang <amwang@redhat.com>2009-06-04 22:12:01 -0400
committerSam Ravnborg <sam@ravnborg.org>2009-06-09 22:37:56 +0200
commit67b7ebe091cd92fd69f732da3170720d79c4e632 (patch)
tree2e56df34060ab6524302c1bff421d229b9d69293
parent7211b8b9028854eee0d03ee6231440b7fb492521 (diff)
downloadlinux-67b7ebe091cd92fd69f732da3170720d79c4e632.tar.bz2
kbuild/headers_check: refine extern check
'extern' checking information is not clear, refine it. Plus, fix a comment. Signed-off-by: WANG Cong <amwang@redhat.com> [sam: redid the extern error message] Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
-rw-r--r--scripts/headers_check.pl12
1 files changed, 7 insertions, 5 deletions
diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl
index 4414c43857ad..db1dd7a549f2 100644
--- a/scripts/headers_check.pl
+++ b/scripts/headers_check.pl
@@ -2,7 +2,7 @@
#
# headers_check.pl execute a number of trivial consistency checks
#
-# Usage: headers_check.pl dir [files...]
+# Usage: headers_check.pl dir arch [files...]
# dir: dir to look for included files
# arch: architecture
# files: list of files to check
@@ -37,7 +37,7 @@ foreach my $file (@files) {
&check_include();
&check_asm_types();
&check_sizetypes();
- &check_prototypes();
+ &check_declarations();
# Dropped for now. Too much noise &check_config();
}
close FH;
@@ -61,10 +61,12 @@ sub check_include
}
}
-sub check_prototypes
+sub check_declarations
{
- if ($line =~ m/^\s*extern\b/) {
- printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
+ if ($line =~m/^\s*extern\b/) {
+ printf STDERR "$filename:$lineno: " .
+ "userspace cannot call function or variable " .
+ "defined in the kernel\n";
}
}