summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPan Bian <bianpan2016@163.com>2019-04-17 16:28:37 +0800
committerUlf Hansson <ulf.hansson@linaro.org>2019-05-06 11:55:39 +0200
commit8e1943af2986db42bee2b8dddf49a36cdb2e9219 (patch)
treecfd89e84e236c807e1597e6670252c18a2ddd131
parent42c38d4a1bc41e78dedbf73b0fb35e44007789bb (diff)
downloadlinux-8e1943af2986db42bee2b8dddf49a36cdb2e9219.tar.bz2
mmc: core: fix possible use after free of host
In the function mmc_alloc_host, the function put_device is called to release allocated resources when mmc_gpio_alloc fails. Finally, the function pointed by host->class_dev.class->dev_release (i.e., mmc_host_classdev_release) is used to release resources including the host structure. However, after put_device, host is used and released again. Resulting in a use-after-free bug. Fixes: 1ed217194488 ("mmc: core: fix error path in mmc_host_alloc") Signed-off-by: Pan Bian <bianpan2016@163.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
-rw-r--r--drivers/mmc/core/host.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index b3fa9c916142..6a51f7a06ce7 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -429,8 +429,6 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
if (mmc_gpio_alloc(host)) {
put_device(&host->class_dev);
- ida_simple_remove(&mmc_host_ida, host->index);
- kfree(host);
return NULL;
}