summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2021-12-30 00:14:23 +0100
committerHans de Goede <hdegoede@redhat.com>2022-01-05 11:31:18 +0100
commitfc64a2b21603dc1e1bae6f34b4bccfadc992894f (patch)
tree49ad336873fb433efb174c2fd27ac1b5942526c7
parent7a4af4b891b875b50ddfeb9b566fcc454744ab04 (diff)
downloadlinux-fc64a2b21603dc1e1bae6f34b4bccfadc992894f.tar.bz2
platform/x86: x86-android-tablets: Don't return -EPROBE_DEFER from a non probe() function
The x86-android-tablets code all runs from module_init, so returning -EPROBE_DEFER is not appropriate. Instead log an error and bail. This path should never get hit since PINCTRL_BAYTRAIL is a bool. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20211229231431.437982-5-hdegoede@redhat.com
-rw-r--r--drivers/platform/x86/x86-android-tablets.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/platform/x86/x86-android-tablets.c b/drivers/platform/x86/x86-android-tablets.c
index 4a04da27a3f4..ea033d7f4439 100644
--- a/drivers/platform/x86/x86-android-tablets.c
+++ b/drivers/platform/x86/x86-android-tablets.c
@@ -63,8 +63,10 @@ static int x86_acpi_irq_helper_get(const struct x86_acpi_irq_data *data)
case X86_ACPI_IRQ_TYPE_GPIOINT:
/* Like acpi_dev_gpio_irq_get(), but without parsing ACPI resources */
chip = gpiochip_find(data->chip, x86_acpi_irq_helper_gpiochip_find);
- if (!chip)
- return -EPROBE_DEFER;
+ if (!chip) {
+ pr_err("error cannot find GPIO chip %s\n", data->chip);
+ return -ENODEV;
+ }
gpiod = gpiochip_get_desc(chip, data->index);
if (IS_ERR(gpiod)) {