diff options
| author | Xiao Ni <xni@redhat.com> | 2021-05-28 14:16:38 +0800 |
|---|---|---|
| committer | Song Liu <song@kernel.org> | 2021-06-10 19:40:14 -0700 |
| commit | 9be148e408df7d361ec5afd6299b7736ff3928b0 (patch) | |
| tree | e6b21a9198837ae3e9d8a48adbc1f6126a9522d6 | |
| parent | 41fe8d088e96472f63164e213de44ec77be69478 (diff) | |
| download | linux-9be148e408df7d361ec5afd6299b7736ff3928b0.tar.bz2 | |
async_xor: check src_offs is not NULL before updating it
When PAGE_SIZE is greater than 4kB, multiple stripes may share the same
page. Thus, src_offs is added to async_xor_offs() with array of offsets.
However, async_xor() passes NULL src_offs to async_xor_offs(). In such
case, src_offs should not be updated. Add a check before the update.
Fixes: ceaf2966ab08(async_xor: increase src_offs when dropping destination page)
Cc: stable@vger.kernel.org # v5.10+
Reported-by: Oleksandr Shchirskyi <oleksandr.shchirskyi@linux.intel.com>
Tested-by: Oleksandr Shchirskyi <oleksandr.shchirskyi@intel.com>
Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Song Liu <song@kernel.org>
| -rw-r--r-- | crypto/async_tx/async_xor.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/crypto/async_tx/async_xor.c b/crypto/async_tx/async_xor.c index 6cd7f7025df4..d8a91521144e 100644 --- a/crypto/async_tx/async_xor.c +++ b/crypto/async_tx/async_xor.c @@ -233,7 +233,8 @@ async_xor_offs(struct page *dest, unsigned int offset, if (submit->flags & ASYNC_TX_XOR_DROP_DST) { src_cnt--; src_list++; - src_offs++; + if (src_offs) + src_offs++; } /* wait for any prerequisite operations */ |