diff options
| author | DENG Qingfang <dqfext@gmail.com> | 2022-02-09 22:39:47 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-02-15 14:21:01 +0000 |
| commit | 525b108e6d95b643eccbd84fb10aa9aa101b18dd (patch) | |
| tree | 39174e7615e6291d3d5ea610841ea6ad94b4e9bb | |
| parent | 032062f363b4bf02b1d547f329aa5d97b6a17410 (diff) | |
| download | linux-525b108e6d95b643eccbd84fb10aa9aa101b18dd.tar.bz2 | |
net: phy: mediatek: remove PHY mode check on MT7531
The function mt7531_phy_mode_supported in the DSA driver set supported
mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
for the internal PHY, so this check breaks the PHY initialization:
mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
Remove the check to make it work again.
Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Tested-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/mediatek-ge.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c index b7a5ae20edd5..68ee434f9dea 100644 --- a/drivers/net/phy/mediatek-ge.c +++ b/drivers/net/phy/mediatek-ge.c @@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev) static int mt7531_phy_config_init(struct phy_device *phydev) { - if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL) - return -EINVAL; - mtk_gephy_config_init(phydev); /* PHY link down power saving enable */ |