summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJens Axboe <axboe@kernel.dk>2021-12-02 12:42:58 -0700
committerJens Axboe <axboe@kernel.dk>2021-12-02 12:42:58 -0700
commit373b5416b4b03ebda5d8f0605b81eff0dc76ebcf (patch)
tree0f767ff78eda18e644dfe698c24cdfa580c55818
parent18d78171c061889a9a43152f60d6a27a10fc7656 (diff)
downloadlinux-373b5416b4b03ebda5d8f0605b81eff0dc76ebcf.tar.bz2
block: get rid of useless goto and label in blk_mq_get_new_requests()
Expected case is returning a request, just check for success and return the request rather than having an error label. Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--block/blk-mq.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c
index ecfc47fad236..ca33cb755c5f 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2720,11 +2720,8 @@ static struct request *blk_mq_get_new_requests(struct request_queue *q,
}
rq = __blk_mq_alloc_requests(&data);
- if (!rq)
- goto fail;
- return rq;
-
-fail:
+ if (rq)
+ return rq;
rq_qos_cleanup(q, bio);
if (bio->bi_opf & REQ_NOWAIT)
bio_wouldblock_error(bio);