diff options
| author | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2022-04-24 19:24:28 +0900 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2022-04-25 08:03:49 +0200 |
| commit | eb9d84b0ffe39893cb23b0b6712bbe3637fa25fa (patch) | |
| tree | 464601a79e4a24b9db845ce3054a8f92c1947b97 | |
| parent | 3b79954fd00d540677c97a560622b73f3a1f4e28 (diff) | |
| download | linux-eb9d84b0ffe39893cb23b0b6712bbe3637fa25fa.tar.bz2 | |
ALSA: fireworks: fix wrong return count shorter than expected by 4 bytes
ALSA fireworks driver has a bug in its initial state to return count
shorter than expected by 4 bytes to userspace applications when handling
response frame for Echo Audio Fireworks transaction. It's due to missing
addition of the size for the type of event in ALSA firewire stack.
Fixes: 555e8a8f7f14 ("ALSA: fireworks: Add command/response functionality into hwdep interface")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20220424102428.21109-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/firewire/fireworks/fireworks_hwdep.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/firewire/fireworks/fireworks_hwdep.c b/sound/firewire/fireworks/fireworks_hwdep.c index 626c0c34b0b6..3a53914277d3 100644 --- a/sound/firewire/fireworks/fireworks_hwdep.c +++ b/sound/firewire/fireworks/fireworks_hwdep.c @@ -34,6 +34,7 @@ hwdep_read_resp_buf(struct snd_efw *efw, char __user *buf, long remained, type = SNDRV_FIREWIRE_EVENT_EFW_RESPONSE; if (copy_to_user(buf, &type, sizeof(type))) return -EFAULT; + count += sizeof(type); remained -= sizeof(type); buf += sizeof(type); |