summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobert Jarzmik <robert.jarzmik@free.fr>2016-04-02 21:38:53 +0200
committerMichal Marek <mmarek@suse.com>2016-05-10 16:55:59 +0200
commit51193b76bfff5027cf96ba63effae808ad67cca7 (patch)
tree72e81989018c0ce974d63f2493126bd6ac5dcacc
parent366f4856f0ef1f3dbdb85b0cc57bef2a77c08b86 (diff)
downloadlinux-51193b76bfff5027cf96ba63effae808ad67cca7.tar.bz2
kbuild: forbid kernel directory to contain spaces and colons
When the kernel path contains a space or a colon somewhere in the path name, the modules_install target doesn't work anymore, as the path names are not enclosed in double quotes. It is also supposed that and O= build will suffer from the same weakness as modules_install. Instead of checking and improving kbuild to resist to directories including these characters, error out early to prevent any build if the kernel's main directory contains a space. Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by: Michal Marek <mmarek@suse.com>
-rw-r--r--Makefile4
1 files changed, 4 insertions, 0 deletions
diff --git a/Makefile b/Makefile
index 5806729cef64..26500ffc5eab 100644
--- a/Makefile
+++ b/Makefile
@@ -128,6 +128,10 @@ _all:
# Cancel implicit rules on top Makefile
$(CURDIR)/Makefile Makefile: ;
+ifneq ($(words $(subst :, ,$(CURDIR))), 1)
+ $(error main directory cannot contain spaces nor colons)
+endif
+
ifneq ($(KBUILD_OUTPUT),)
# Invoke a second make in the output directory, passing relevant variables
# check that the output directory actually exists