diff options
| author | Shuqi Zhang <zhangshuqi3@huawei.com> | 2022-05-25 11:01:20 +0800 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2022-06-18 19:35:43 -0400 |
| commit | 4efd9f0d120c55b08852ee5605dbb02a77089a5d (patch) | |
| tree | 8631c70c8ac72a5781db94774f70f636a35dfcb0 | |
| parent | 9b6641dd95a0c441b277dd72ba22fed8d61f76ad (diff) | |
| download | linux-4efd9f0d120c55b08852ee5605dbb02a77089a5d.tar.bz2 | |
ext4: use kmemdup() to replace kmalloc + memcpy
Replace kmalloc + memcpy with kmemdup()
Signed-off-by: Shuqi Zhang <zhangshuqi3@huawei.com>
Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/20220525030120.803330-1-zhangshuqi3@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/xattr.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 042325349098..564e28a1aa94 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1895,11 +1895,10 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode, unlock_buffer(bs->bh); ea_bdebug(bs->bh, "cloning"); - s->base = kmalloc(bs->bh->b_size, GFP_NOFS); + s->base = kmemdup(BHDR(bs->bh), bs->bh->b_size, GFP_NOFS); error = -ENOMEM; if (s->base == NULL) goto cleanup; - memcpy(s->base, BHDR(bs->bh), bs->bh->b_size); s->first = ENTRY(header(s->base)+1); header(s->base)->h_refcount = cpu_to_le32(1); s->here = ENTRY(s->base + offset); |