diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2022-04-11 21:07:52 +0300 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2022-04-15 23:30:59 +0200 |
| commit | aef80e2fbe3ec6264e935cebfb8fa3367cb1e7b0 (patch) | |
| tree | f0e322bb82a3dbd90a777e8778c58d4cc05db406 | |
| parent | 993eb48fa199b5f476df8204e652eff63dd19361 (diff) | |
| download | linux-aef80e2fbe3ec6264e935cebfb8fa3367cb1e7b0.tar.bz2 | |
i2c: dev: Force case user pointers in compat_i2cdev_ioctl()
Sparse has warned us about wrong address space for user pointers:
i2c-dev.c:561:50: warning: incorrect type in initializer (different address spaces)
i2c-dev.c:561:50: expected unsigned char [usertype] *buf
i2c-dev.c:561:50: got void [noderef] __user *
Force cast the pointer to (__u8 *) that is used by I²C core code.
Note, this is an additional fix to the previously addressed similar issue
in the I2C_RDWR case in the same function.
Fixes: 3265a7e6b41b ("i2c: dev: Add __user annotation")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
| -rw-r--r-- | drivers/i2c/i2c-dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 6fd2b6718b08..ab0adaa130da 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -557,7 +557,7 @@ static long compat_i2cdev_ioctl(struct file *file, unsigned int cmd, unsigned lo .addr = umsg.addr, .flags = umsg.flags, .len = umsg.len, - .buf = compat_ptr(umsg.buf) + .buf = (__force __u8 *)compat_ptr(umsg.buf), }; } |