diff options
| author | Gabriel Krisman Bertazi <krisman@collabora.com> | 2021-10-26 14:33:02 -0300 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2021-11-04 10:47:39 -0400 |
| commit | 124e7c61deb27d758df5ec0521c36cf08d417f7a (patch) | |
| tree | 80bb18d72cf8009781ebca64f5b74f78041a9397 | |
| parent | 1ebf21784b19d5bc269f39a5d1eedb7f29a7d152 (diff) | |
| download | linux-124e7c61deb27d758df5ec0521c36cf08d417f7a.tar.bz2 | |
ext4: fix error code saved on super block during file system abort
ext4_abort will eventually call ext4_errno_to_code, which translates the
errno to an EXT4_ERR specific error. This means that ext4_abort expects
an errno. By using EXT4_ERR_ here, it gets misinterpreted (as an errno),
and ends up saving EXT4_ERR_EBUSY on the superblock during an abort,
which makes no sense.
ESHUTDOWN will get properly translated to EXT4_ERR_SHUTDOWN, so use that
instead.
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Link: https://lore.kernel.org/r/20211026173302.84000-1-krisman@collabora.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 160e58249482..0e8406f5bf0a 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5820,7 +5820,7 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data) } if (ext4_test_mount_flag(sb, EXT4_MF_FS_ABORTED)) - ext4_abort(sb, EXT4_ERR_ESHUTDOWN, "Abort forced by user"); + ext4_abort(sb, ESHUTDOWN, "Abort forced by user"); sb->s_flags = (sb->s_flags & ~SB_POSIXACL) | (test_opt(sb, POSIX_ACL) ? SB_POSIXACL : 0); |