diff options
| author | Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-09-06 22:29:57 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-09-07 18:10:34 +0200 |
| commit | 7ccd451912dd6407957676ae584248bdadc97b38 (patch) | |
| tree | 3b3177b1e454a1409960f5b8a1c8eb1121f203c0 | |
| parent | fcd8c627090a303c3f014b044f4c57e5b11b5311 (diff) | |
| download | linux-7ccd451912dd6407957676ae584248bdadc97b38.tar.bz2 | |
net/tls: unref frags in order
It's generally more cache friendly to walk arrays in order,
especially those which are likely not in cache.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/tls/tls_device.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index 41c106e45f01..285c9f9e94e4 100644 --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -122,13 +122,10 @@ static struct net_device *get_netdev_for_sock(struct sock *sk) static void destroy_record(struct tls_record_info *record) { - int nr_frags = record->num_frags; - skb_frag_t *frag; + int i; - while (nr_frags-- > 0) { - frag = &record->frags[nr_frags]; - __skb_frag_unref(frag); - } + for (i = 0; i < record->num_frags; i++) + __skb_frag_unref(&record->frags[i]); kfree(record); } |