summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAvri Altman <avri.altman@wdc.com>2021-08-08 12:00:24 +0300
committerMartin K. Petersen <martin.petersen@oracle.com>2021-08-11 22:25:36 -0400
commit10163cee1f06fc2e17bcf7bbc2982337202d1d5c (patch)
treec49ce0d2e442575c777ef48ee3138b6a3e5329c6
parent22aede9f48b6766fb67441610120db9b04adf109 (diff)
downloadlinux-10163cee1f06fc2e17bcf7bbc2982337202d1d5c.tar.bz2
scsi: ufs: ufshpb: Do not report victim error in HCM
In host control mode, eviction is perceived as an extreme measure. There are several conditions that both the entering and exiting regions should meet, so that eviction will take place. The common case however, is that those conditions are rarely met, so it is normal that the act of eviction fails. Therefore, do not report an error in host control mode if eviction fails. Link: https://lore.kernel.org/r/20210808090024.21721-5-avri.altman@wdc.com Fixes: 6c59cb501b86 (scsi: ufs: ufshpb: Make eviction depend on region's reads) Signed-off-by: Avri Altman <avri.altman@wdc.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r--drivers/scsi/ufs/ufshpb.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index cd48367f94cc..aafb55136c7e 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -1385,7 +1385,8 @@ static int ufshpb_add_region(struct ufshpb_lu *hpb, struct ufshpb_region *rgn)
victim_rgn = ufshpb_victim_lru_info(hpb);
if (!victim_rgn) {
dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
- "cannot get victim region error\n");
+ "cannot get victim region %s\n",
+ hpb->is_hcm ? "" : "error");
ret = -ENOMEM;
goto out;
}