diff options
| author | Ronnie Sahlberg <lsahlber@redhat.com> | 2019-04-10 07:47:22 +1000 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2019-04-16 09:38:26 -0500 |
| commit | e6d0fb7b34f264f72c33053558a360a6a734905e (patch) | |
| tree | 5b0981d05bd73ae29925e651ee77a52ddd8fed82 | |
| parent | b57a55e2200ede754e4dc9cce4ba9402544b9365 (diff) | |
| download | linux-e6d0fb7b34f264f72c33053558a360a6a734905e.tar.bz2 | |
cifs: fix handle leak in smb2_query_symlink()
If we enter smb2_query_symlink() for something that is not a symlink
and where the SMB2_open() would succeed we would never end up
closing this handle and would thus leak a handle on the server.
Fix this by immediately calling SMB2_close() on successfull open.
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
| -rw-r--r-- | fs/cifs/smb2ops.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 00225e699d03..c36ff0d1fe2a 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -2389,6 +2389,8 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, rc = SMB2_open(xid, &oparms, utf16_path, &oplock, NULL, &err_iov, &resp_buftype); + if (!rc) + SMB2_close(xid, tcon, fid.persistent_fid, fid.volatile_fid); if (!rc || !err_iov.iov_base) { rc = -ENOENT; goto free_path; |