diff options
| author | Yangtao Li <tiny.windzz@gmail.com> | 2018-12-10 11:26:41 -0500 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2018-12-11 12:09:48 +0100 |
| commit | 9456823c842f346c74265fcd98d008d87a7eb6f5 (patch) | |
| tree | 44686cfd5ce4bdc33278efbadcd0630c026f39ab | |
| parent | 61cb5758d3c46bc1ba87694fefc0d9653613ce6b (diff) | |
| download | linux-9456823c842f346c74265fcd98d008d87a7eb6f5.tar.bz2 | |
cpuidle: big.LITTLE: fix refcount leak
of_find_node_by_path() acquires a reference to the node
returned by it and that reference needs to be dropped by its caller.
bl_idle_init() doesn't do that, so fix it.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/cpuidle/cpuidle-big_little.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c index db2ede565f1a..b44476a1b7ad 100644 --- a/drivers/cpuidle/cpuidle-big_little.c +++ b/drivers/cpuidle/cpuidle-big_little.c @@ -167,6 +167,7 @@ static int __init bl_idle_init(void) { int ret; struct device_node *root = of_find_node_by_path("/"); + const struct of_device_id *match_id; if (!root) return -ENODEV; @@ -174,7 +175,11 @@ static int __init bl_idle_init(void) /* * Initialize the driver just for a compliant set of machines */ - if (!of_match_node(compatible_machine_match, root)) + match_id = of_match_node(compatible_machine_match, root); + + of_node_put(root); + + if (!match_id) return -ENODEV; if (!mcpm_is_available()) |