diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2012-11-16 22:12:28 -0800 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2012-11-19 03:05:15 -0800 |
commit | dd34ad35c32bb3d16789d8d4084aead7e68a7b09 (patch) | |
tree | 6acf9d527a91cd8320bc017b74f3c782cfc0aedc | |
parent | 038e7332b8d4c0629a2965e3ede1a92e8e427bd6 (diff) | |
download | linux-dd34ad35c32bb3d16789d8d4084aead7e68a7b09.tar.bz2 |
userns: On mips modify check_same_owner to use uid_eq
The kbuild test robot <fengguang.wu@intel.com> report the following error
when building mips with user namespace support enabled.
All error/warnings:
arch/mips/kernel/mips-mt-fpaff.c: In function 'check_same_owner':
arch/mips/kernel/mips-mt-fpaff.c:53:22: error: invalid operands to binary == (have 'kuid_t' and 'kuid_t')
arch/mips/kernel/mips-mt-fpaff.c:54:15: error: invalid operands to binary == (have 'kuid_t' and 'kuid_t')
Replace "a == b" with uid_eq(a, b) removes this error and allows the
code to work with user namespaces enabled.
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
-rw-r--r-- | arch/mips/kernel/mips-mt-fpaff.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/mips/kernel/mips-mt-fpaff.c b/arch/mips/kernel/mips-mt-fpaff.c index 33f63bab478a..fd814e08c945 100644 --- a/arch/mips/kernel/mips-mt-fpaff.c +++ b/arch/mips/kernel/mips-mt-fpaff.c @@ -50,8 +50,8 @@ static bool check_same_owner(struct task_struct *p) rcu_read_lock(); pcred = __task_cred(p); - match = (cred->euid == pcred->euid || - cred->euid == pcred->uid); + match = (uid_eq(cred->euid, pcred->euid) || + uid_eq(cred->euid, pcred->uid)); rcu_read_unlock(); return match; } |