summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFinn Thain <fthain@telegraphics.com.au>2016-01-03 16:05:20 +1100
committerMartin K. Petersen <martin.petersen@oracle.com>2016-01-06 21:42:55 -0500
commite52bbd5ccf53d2a73e524adb26b6d8a4f810ccb4 (patch)
tree8661df0ae59be9448097a9fbe2c3d93dd37b7db5
parent4d029e9ae9c382b149b16632f49970d8b215e2da (diff)
downloadlinux-e52bbd5ccf53d2a73e524adb26b6d8a4f810ccb4.tar.bz2
ncr5380: Cleanup bogus {request,release}_region() calls
Commit 8b801ead3d7a ("[ARM] rpc: update Acorn SCSI drivers to modern ecard interfaces") neglected to remove a request_region() call in cumana_1.c. Commit eda32612f7b2 ("[PATCH] give all LLDD driver a ->release method") in history/history.git added some pointless release_region() calls in dtc.c, pas16.c and t128.c. Fix these issues. Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Reviewed-by: Hannes Reinecke <hare@suse.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r--drivers/scsi/arm/cumana_1.c6
-rw-r--r--drivers/scsi/dtc.c2
-rw-r--r--drivers/scsi/pas16.c2
-rw-r--r--drivers/scsi/t128.c2
4 files changed, 0 insertions, 12 deletions
diff --git a/drivers/scsi/arm/cumana_1.c b/drivers/scsi/arm/cumana_1.c
index c7dc65e39cdb..3b5ff105f1d6 100644
--- a/drivers/scsi/arm/cumana_1.c
+++ b/drivers/scsi/arm/cumana_1.c
@@ -245,12 +245,6 @@ static int cumanascsi1_probe(struct expansion_card *ec,
priv(host)->ctrl = 0;
writeb(0, priv(host)->base + CTRL);
- host->n_io_port = 255;
- if (!(request_region(host->io_port, host->n_io_port, "CumanaSCSI-1"))) {
- ret = -EBUSY;
- goto out_unmap;
- }
-
ret = request_irq(host->irq, cumanascsi_intr, 0,
"CumanaSCSI-1", host);
if (ret) {
diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
index 02a5532f4267..698bea067af9 100644
--- a/drivers/scsi/dtc.c
+++ b/drivers/scsi/dtc.c
@@ -423,8 +423,6 @@ static int dtc_release(struct Scsi_Host *shost)
if (shost->irq != NO_IRQ)
free_irq(shost->irq, shost);
NCR5380_exit(shost);
- if (shost->io_port && shost->n_io_port)
- release_region(shost->io_port, shost->n_io_port);
scsi_unregister(shost);
iounmap(hostdata->base);
return 0;
diff --git a/drivers/scsi/pas16.c b/drivers/scsi/pas16.c
index c316ff7ffef6..e5c76eefa5e0 100644
--- a/drivers/scsi/pas16.c
+++ b/drivers/scsi/pas16.c
@@ -540,8 +540,6 @@ static int pas16_release(struct Scsi_Host *shost)
if (shost->irq != NO_IRQ)
free_irq(shost->irq, shost);
NCR5380_exit(shost);
- if (shost->io_port && shost->n_io_port)
- release_region(shost->io_port, shost->n_io_port);
scsi_unregister(shost);
return 0;
}
diff --git a/drivers/scsi/t128.c b/drivers/scsi/t128.c
index d5e6b676d75e..3adcae1150d2 100644
--- a/drivers/scsi/t128.c
+++ b/drivers/scsi/t128.c
@@ -255,8 +255,6 @@ static int t128_release(struct Scsi_Host *shost)
if (shost->irq != NO_IRQ)
free_irq(shost->irq, shost);
NCR5380_exit(shost);
- if (shost->io_port && shost->n_io_port)
- release_region(shost->io_port, shost->n_io_port);
scsi_unregister(shost);
iounmap(hostdata->base);
return 0;