diff options
| author | Julian Wiedmann <jwi@linux.ibm.com> | 2019-02-28 18:59:40 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-02-28 12:55:26 -0800 |
| commit | 464e86dafcca14e5f7a7157fc567c58654ec80b3 (patch) | |
| tree | 94d3059d98e730563c6b5eaf3e9255334d93ee88 | |
| parent | d4560150cb47daba50b0d080550ca4bbe80cf3c3 (diff) | |
| download | linux-464e86dafcca14e5f7a7157fc567c58654ec80b3.tar.bz2 | |
s390/qeth: remove a redundant check for card->dev
smatch complains that __qeth_l3_set_offline() first accesses card->dev,
and then later checks whether the pointer is valid.
Since commit d3d1b205e89f ("s390/qeth: allocate netdevice early"), the
pointer is _always_ valid - that patch merely missed to remove this one
check.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/s390/net/qeth_l3_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c index 1381e7e312cd..13d77957404c 100644 --- a/drivers/s390/net/qeth_l3_main.c +++ b/drivers/s390/net/qeth_l3_main.c @@ -2414,7 +2414,7 @@ static int __qeth_l3_set_offline(struct ccwgroup_device *cgdev, rtnl_unlock(); qeth_l3_stop_card(card); - if ((card->options.cq == QETH_CQ_ENABLED) && card->dev) { + if (card->options.cq == QETH_CQ_ENABLED) { rtnl_lock(); call_netdevice_notifiers(NETDEV_REBOOT, card->dev); rtnl_unlock(); |