diff options
| author | Yuval Mintz <Yuval.Mintz@qlogic.com> | 2016-06-04 08:20:16 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-06-03 22:42:26 -0700 |
| commit | 81b1251d3b761b303955408dd6a49618b5683c2b (patch) | |
| tree | 1a5719ba93f79c7d19bd45c1bc55d1255fa30d71 | |
| parent | 03c7f70beee4c5d34881e5d3dd2b6f3e848047ef (diff) | |
| download | linux-81b1251d3b761b303955408dd6a49618b5683c2b.tar.bz2 | |
qed: Fix next-ptr chains for BE / 32-bit
Commit a91eb52abb50 ("qed: Revisit chain implementation") contains an
incorrect implementation for BE platforms, as device's regpairs containing
addresses are LE and they're not converted correctly when read back.
In addition, it raises a compilation warning for 32-bit platforms where
dma_addr_t is a 32-bit variable.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | include/linux/qed/qed_chain.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/linux/qed/qed_chain.h b/include/linux/qed/qed_chain.h index eceaa9ed2ae9..7e441bdeabdc 100644 --- a/include/linux/qed/qed_chain.h +++ b/include/linux/qed/qed_chain.h @@ -25,10 +25,9 @@ } while (0) #define HILO_GEN(hi, lo, type) ((((type)(hi)) << 32) + (lo)) -#define HILO_DMA(hi, lo) HILO_GEN(hi, lo, dma_addr_t) #define HILO_64(hi, lo) HILO_GEN((le32_to_cpu(hi)), (le32_to_cpu(lo)), u64) -#define HILO_DMA_REGPAIR(regpair) (HILO_DMA(regpair.hi, regpair.lo)) #define HILO_64_REGPAIR(regpair) (HILO_64(regpair.hi, regpair.lo)) +#define HILO_DMA_REGPAIR(regpair) ((dma_addr_t)HILO_64_REGPAIR(regpair)) enum qed_chain_mode { /* Each Page contains a next pointer at its end */ |