diff options
| author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2008-08-31 11:06:30 -0700 |
|---|---|---|
| committer | Tony Luck <tony.luck@intel.com> | 2008-09-10 10:52:42 -0700 |
| commit | e7b140365b86aaf94374214c6f4e6decbee2eb0a (patch) | |
| tree | 6467805ada12be5cd1d5136869bf1f031f441999 | |
| parent | 6bf6a1a49377c32a02939ec835553703994f3e41 (diff) | |
| download | linux-e7b140365b86aaf94374214c6f4e6decbee2eb0a.tar.bz2 | |
[IA64] prevent ia64 from invoking irq handlers on offline CPUs
Make ia64 refrain from clearing a given to-be-offlined CPU's bit in the
cpu_online_mask until it has processed pending irqs. This change
prevents other CPUs from being blindsided by an apparently offline CPU
nevertheless changing globally visible state. Also remove the existing
redundant cpu_clear(cpu, cpu_online_map).
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
| -rw-r--r-- | arch/ia64/kernel/smpboot.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c index bcea81e432fd..d8f05e504fbf 100644 --- a/arch/ia64/kernel/smpboot.c +++ b/arch/ia64/kernel/smpboot.c @@ -741,16 +741,14 @@ int __cpu_disable(void) return -EBUSY; } - cpu_clear(cpu, cpu_online_map); - if (migrate_platform_irqs(cpu)) { cpu_set(cpu, cpu_online_map); return (-EBUSY); } remove_siblinginfo(cpu); - cpu_clear(cpu, cpu_online_map); fixup_irqs(); + cpu_clear(cpu, cpu_online_map); local_flush_tlb_all(); cpu_clear(cpu, cpu_callin_map); return 0; |