summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2010-10-23 11:16:10 -0400
committerJ. Bruce Fields <bfields@redhat.com>2010-10-25 17:59:32 -0400
commitac9303eb74471bc2567960b47497a8bfbe1e5a03 (patch)
tree17f9882d81b56d2787d0c556cfa6d76ea40a948b
parent7e4fdd0744fcb9f08854c37643bf529c5945cc36 (diff)
downloadlinux-ac9303eb74471bc2567960b47497a8bfbe1e5a03.tar.bz2
svcrpc: assume svc_delete_xprt() called only once
As long as DEAD exports are left BUSY, and svc_delete_xprt is called only with BUSY held, then svc_delete_xprt() will never be called on an xprt that is already DEAD. Signed-off-by: J. Bruce Fields <bfields@redhat.com>
-rw-r--r--net/sunrpc/svc_xprt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index 1b0673c6e986..c65a47218290 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -903,7 +903,7 @@ void svc_delete_xprt(struct svc_xprt *xprt)
/* Only do this once */
if (test_and_set_bit(XPT_DEAD, &xprt->xpt_flags))
- return;
+ BUG();
dprintk("svc: svc_delete_xprt(%p)\n", xprt);
xprt->xpt_ops->xpo_detach(xprt);