summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2013-10-29 15:07:19 +0100
committerTakashi Iwai <tiwai@suse.de>2013-10-29 15:07:19 +0100
commita8d09e3a6dfc44fd2246f3c57d2cd00e1a56e2bd (patch)
tree388221310817c32736967e0622027c93ebb0c7e4
parenta40a3937222c728be925f2d78650cfe9b20be3f5 (diff)
downloadlinux-a8d09e3a6dfc44fd2246f3c57d2cd00e1a56e2bd.tar.bz2
ALSA: opl3: Fix possible negative array index access
Spotted by coverity CID 115196. Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/drivers/opl3/opl3_midi.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/sound/drivers/opl3/opl3_midi.c b/sound/drivers/opl3/opl3_midi.c
index 0c796bcbc0a3..6c6d09a51f42 100644
--- a/sound/drivers/opl3/opl3_midi.c
+++ b/sound/drivers/opl3/opl3_midi.c
@@ -390,6 +390,11 @@ void snd_opl3_note_on(void *p, int note, int vel, struct snd_midi_channel *chan)
voice = snd_opl3_oss_map[chan->number];
}
+ if (voice < 0) {
+ spin_unlock_irqrestore(&opl3->voice_lock, flags);
+ return;
+ }
+
if (voice < MAX_OPL2_VOICES) {
/* Left register block for voices 0 .. 8 */
reg_side = OPL3_LEFT;