summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenis Efremov <efremov@linux.com>2018-08-10 23:25:55 +0300
committerMasahiro Yamada <yamada.masahiro@socionext.com>2018-08-14 08:58:56 +0900
commit512ddf7d7db056edfed3159ea7cb4e4a5eefddd4 (patch)
treed4ab5068f95916e5493aaaaf546219a9001fe64a
parent09d4d9648bd01a4c124fcc30dd0c31503975e8c2 (diff)
downloadlinux-512ddf7d7db056edfed3159ea7cb4e4a5eefddd4.tar.bz2
coccicheck: return proper error code on fail
If coccicheck fails, it should return an error code distinct from zero to signal about an internal problem. Current code instead of exiting with the tool's error code returns the error code of 'echo "coccicheck failed"' which is almost always equals to zero, thus failing the original intention of alerting about a problem. This patch fixes the code. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Denis Efremov <efremov@linux.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
-rwxr-xr-xscripts/coccicheck5
1 files changed, 3 insertions, 2 deletions
diff --git a/scripts/coccicheck b/scripts/coccicheck
index 9fedca611b7f..e04d328210ac 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -128,9 +128,10 @@ run_cmd_parmap() {
fi
echo $@ >>$DEBUG_FILE
$@ 2>>$DEBUG_FILE
- if [[ $? -ne 0 ]]; then
+ err=$?
+ if [[ $err -ne 0 ]]; then
echo "coccicheck failed"
- exit $?
+ exit $err
fi
}