diff options
| author | David S. Miller <davem@davemloft.net> | 2009-03-29 01:19:37 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-03-29 01:19:37 -0700 |
| commit | ee76db5e9e9896312f001790855a798472440328 (patch) | |
| tree | 7a83b12a69689dbde07fd545a48cbd8a771c3fe3 | |
| parent | 2c60b6885afc56a17b9d55b04c4328123063fc9d (diff) | |
| download | linux-ee76db5e9e9896312f001790855a798472440328.tar.bz2 | |
gianfar: Fix use-after-of_node_put() in gfar_of_init().
We can't put 'mdio' until after we've used it in the
fsl_pq_mdio_bus_name() call.
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/gianfar.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 6a38800be3f1..65f55877be95 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -289,9 +289,9 @@ static int gfar_of_init(struct net_device *dev) id = of_get_property(phy, "reg", NULL); of_node_put(phy); - of_node_put(mdio); fsl_pq_mdio_bus_name(bus_name, mdio); + of_node_put(mdio); snprintf(priv->phy_bus_id, sizeof(priv->phy_bus_id), "%s:%02x", bus_name, *id); } |