summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorValentin Rothberg <valentinrothberg@gmail.com>2015-03-23 18:40:49 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-24 15:18:44 +0100
commite9533ae539d5cc3d5fc501529d2df7b77e20449c (patch)
tree9dc0125bdc33460c5b89aecc48d6e0b70e5f2919
parenta087146c72bad795bcab80e5987c5b80fa225000 (diff)
downloadlinux-e9533ae539d5cc3d5fc501529d2df7b77e20449c.tar.bz2
checkkconfigsymbols.py: fix sorted output
Commit b1a3f243485f ("checkkconfigsymbols.py: make it Git aware") mistakenly removed to print undefined Kconfig symbols in alphabetical order. Furthermore, the script does not print anything anymore when the entire tree is checked (i.e., when no commit is specified). This patch restores the sorted output and adds the missing print for the default case. Additionally, the file lists are now sorted as well which (a) makes it easier to read and (b) makes the output deterministic. Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rwxr-xr-xscripts/checkkconfigsymbols.py12
1 files changed, 7 insertions, 5 deletions
diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
index ce9ca60808b8..74086a583d8d 100755
--- a/scripts/checkkconfigsymbols.py
+++ b/scripts/checkkconfigsymbols.py
@@ -112,14 +112,15 @@ def main():
undefined_b = check_symbols()
# report cases that are present for the commit but not before
- for feature in undefined_b:
+ for feature in sorted(undefined_b):
# feature has not been undefined before
if not feature in undefined_a:
- files = undefined_b.get(feature)
+ files = sorted(undefined_b.get(feature))
print "%s\t%s" % (feature, ", ".join(files))
# check if there are new files that reference the undefined feature
else:
- files = undefined_b.get(feature) - undefined_a.get(feature)
+ files = sorted(undefined_b.get(feature) -
+ undefined_a.get(feature))
if files:
print "%s\t%s" % (feature, ", ".join(files))
@@ -129,8 +130,9 @@ def main():
# default to check the entire tree
else:
undefined = check_symbols()
- for feature in undefined:
- files = undefined.get(feature)
+ for feature in sorted(undefined):
+ files = sorted(undefined.get(feature))
+ print "%s\t%s" % (feature, ", ".join(files))
def execute(cmd):