diff options
| author | Dave Chinner <dchinner@redhat.com> | 2013-09-02 10:32:01 +1000 |
|---|---|---|
| committer | Ben Myers <bpm@sgi.com> | 2013-09-10 13:34:05 -0500 |
| commit | 0a4edc8f0b54cd5f613e7fda7dc8106cb9869bc9 (patch) | |
| tree | 79182ecb80b5bac9d78af62ea7365a8bc2202e50 | |
| parent | daf7b799a944d28a50caaa512011f5a0eb5a4076 (diff) | |
| download | linux-0a4edc8f0b54cd5f613e7fda7dc8106cb9869bc9.tar.bz2 | |
xfs: ensure we copy buffer type in da btree root splits
When splitting the root of the da btree, we shuffled data between
buffers and the structures that track them. At one point, we copy
data and state from one buffer to another, including the ops
associated with the buffer. When we do this, we also need to copy
the buffer type associated with the buf log item so that the buffer
is logged correctly. If we don't do that, log recovery won't
recognise it and hence it won't recalculate the CRC on the buffer
after recovery. This leads to a directory block that can't be read
after recovery has run.
Found by inspection after finding the same problem with remote
symlink buffers.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
| -rw-r--r-- | fs/xfs/xfs_da_btree.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/xfs/xfs_da_btree.c b/fs/xfs/xfs_da_btree.c index d4e59a4ff59f..069537c845e5 100644 --- a/fs/xfs/xfs_da_btree.c +++ b/fs/xfs/xfs_da_btree.c @@ -635,6 +635,7 @@ xfs_da3_root_split( xfs_trans_log_buf(tp, bp, 0, size - 1); bp->b_ops = blk1->bp->b_ops; + xfs_trans_buf_copy_type(bp, blk1->bp); blk1->bp = bp; blk1->blkno = blkno; |