diff options
| author | Jiri Pirko <jiri@resnulli.us> | 2014-04-23 14:17:55 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-04-24 13:26:32 -0400 |
| commit | ed2da03c6907800871234f5cae42db7d80de8dfc (patch) | |
| tree | a6d440a522700eac2429ee63264df55ae1360ecf | |
| parent | 8ea2b17c99b926e2229696eed7f49ac2f73f4619 (diff) | |
| download | linux-ed2da03c6907800871234f5cae42db7d80de8dfc.tar.bz2 | |
team: forbid incorrect fall-through in notifier
There are two breaks missing there. The result is that userspace
receives multiple messages which might be confusing.
Introduced-by: 3d249d4c "net: introduce ethernet teaming device"
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/team/team.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 33008c1d1d67..767fe61b5ac9 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -2834,8 +2834,10 @@ static int team_device_event(struct notifier_block *unused, case NETDEV_UP: if (netif_carrier_ok(dev)) team_port_change_check(port, true); + break; case NETDEV_DOWN: team_port_change_check(port, false); + break; case NETDEV_CHANGE: if (netif_running(port->dev)) team_port_change_check(port, |