summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjørn Mork <bjorn@mork.no>2013-01-25 23:36:59 +0000
committerDavid S. Miller <davem@davemloft.net>2013-01-27 19:27:39 -0500
commit56a666dcfcb46e998a1bd969fb201bf51de3c412 (patch)
tree31d4a677a641d633408ac5068b0c6c1100341576
parent2afd0a24da6c63ad3c1af1c510cb91c7befdc8d0 (diff)
downloadlinux-56a666dcfcb46e998a1bd969fb201bf51de3c412.tar.bz2
net: cdc_ncm: use IAD provided by the USB core
commit 9992c2e (net: cdc_ncm: workaround for missing CDC Union) added code to lookup an IAD for the interface we are probing. This is redundant. The USB core has already done the lookup and saved the result in the USB interface struct. Use that instead. Cc: Greg Suarez <gsuarez@smithmicro.com> Cc: Alexey Orishko <alexey.orishko@stericsson.com> Signed-off-by: Bjørn Mork <bjorn@mork.no> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/usb/cdc_ncm.c28
1 files changed, 4 insertions, 24 deletions
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index f94711caa08a..9197b2c72ca3 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -344,23 +344,6 @@ static const struct ethtool_ops cdc_ncm_ethtool_ops = {
.nway_reset = usbnet_nway_reset,
};
-/* return first slave interface if an IAD matches the given master */
-static struct usb_interface *get_iad_slave(struct usb_device *udev,
- struct usb_interface *master) {
- int i;
- struct usb_interface_assoc_descriptor *iad;
- u8 mnum = master->cur_altsetting->desc.bInterfaceNumber;
-
- for (i = 0; i < USB_MAXIADS; i++) {
- iad = udev->actconfig->intf_assoc[i];
- if (!iad)
- break;
- if (iad->bFirstInterface == mnum && iad->bInterfaceCount == 2)
- return usb_ifnum_to_if(udev, mnum + 1);
- }
- return NULL;
-}
-
int cdc_ncm_bind_common(struct usbnet *dev, struct usb_interface *intf, u8 data_altsetting)
{
struct cdc_ncm_ctx *ctx;
@@ -453,13 +436,10 @@ advance:
}
/* some buggy devices have an IAD but no CDC Union */
- if (!ctx->union_desc) {
- dev_dbg(&intf->dev, "missing CDC Union descriptor\n");
- ctx->data = get_iad_slave(dev->udev, intf);
- if (ctx->data) {
- ctx->control = intf;
- dev_dbg(&intf->dev, "got slave from IAD\n");
- }
+ if (!ctx->union_desc && intf->intf_assoc && intf->intf_assoc->bInterfaceCount == 2) {
+ ctx->control = intf;
+ ctx->data = usb_ifnum_to_if(dev->udev, intf->cur_altsetting->desc.bInterfaceNumber + 1);
+ dev_dbg(&intf->dev, "CDC Union missing - got slave from IAD\n");
}
/* check if we got everything */