diff options
| author | Davy Chan <chandave-linux-mips@wiasia.com> | 2007-01-05 13:56:46 +0800 |
|---|---|---|
| committer | Ralf Baechle <ralf@linux-mips.org> | 2007-01-08 21:41:04 +0000 |
| commit | d98f92371461c5c8cc24e12a212c59b3f437b581 (patch) | |
| tree | 690b50b3a8809f55d2b747f8125189d0413d205b | |
| parent | f75f369fd783d194cb45632617561ca4d7045849 (diff) | |
| download | linux-d98f92371461c5c8cc24e12a212c59b3f437b581.tar.bz2 | |
[MIPS] pnx8550: Fix write_config_byte() PCI config space accessor
There's a serious typo in the function:
arch/mips/pci/ops-pnx8550.c:write_config_byte()
The parameter passed to the function config_access() is PCI_CMD_CONFIG_READ
instead of PCI_CMD_CONFIG_WRITE. This renders any attempts to write
a single byte to the PCI configuration registers useless.
This problem does not exist for write_config_word() nor write_config_dword().
This problem has been there since kernel v2.6.17 and is still there
as of kernel v2.6.19.1.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
| -rw-r--r-- | arch/mips/pci/ops-pnx8550.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/pci/ops-pnx8550.c b/arch/mips/pci/ops-pnx8550.c index 454b65cc3354..f556b7a8dccd 100644 --- a/arch/mips/pci/ops-pnx8550.c +++ b/arch/mips/pci/ops-pnx8550.c @@ -202,7 +202,7 @@ write_config_byte(struct pci_bus *bus, unsigned int devfn, int where, u8 val) break; } - err = config_access(PCI_CMD_CONFIG_READ, bus, devfn, where, ~(1 << (where & 3)), &data); + err = config_access(PCI_CMD_CONFIG_WRITE, bus, devfn, where, ~(1 << (where & 3)), &data); return err; } |