summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@gmail.com>2011-10-31 14:23:03 +0800
committerSamuel Ortiz <sameo@linux.intel.com>2011-12-20 18:50:56 +0100
commitaf65e6cef488be0bd15932c8ce9801a47a183051 (patch)
tree2d499cce07dc1d618ed273df3b368e332a3e3e45
parent890c98e3746fa8705cc9c70979e64360cf2d8a31 (diff)
downloadlinux-af65e6cef488be0bd15932c8ce9801a47a183051.tar.bz2
mfd: Set da903x bits if new value is different from the old one
It does not make sense to write new value only when all the bit_mask bits are zero. We need to write new value if the bit mask fields of new value is not equal to old value. Signed-off-by: Axel Lin <axel.lin@gmail.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
-rw-r--r--drivers/mfd/da903x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
index 62ce685a79cb..1924b857a0fb 100644
--- a/drivers/mfd/da903x.c
+++ b/drivers/mfd/da903x.c
@@ -182,7 +182,7 @@ int da903x_set_bits(struct device *dev, int reg, uint8_t bit_mask)
if (ret)
goto out;
- if ((reg_val & bit_mask) == 0) {
+ if ((reg_val & bit_mask) != bit_mask) {
reg_val |= bit_mask;
ret = __da903x_write(chip->client, reg, reg_val);
}